(SUP-2677) Deprecate backup functionality #91
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pe_databases is a classthat may have no external impact to Forge modules. This module is declared in 0 of 578 indexed public
|
MartyEwings
requested changes
Sep 24, 2021
| @@ -47,6 +47,10 @@ | |||
| class { 'pe_databases::backup': | |||
| disable_maintenance => ! $manage_database_backups, | |||
| } | |||
| notify { 'pe_databases_backup_deprecate_warn': | |||
| message => 'The backup functionality in the pe_databases module has been deprecated and will be removed in a future release.', | |||
There was a problem hiding this comment.
This and the line below need to be indented
|
closing to reopen using new logic that has been merged rather than rebasing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a warning if the parameter
manage_database_backupsis defined to output a deprecated message.This only outputs to puppetserver.log and not during agent runs:
2021-09-23T11:33:26.289Z WARN [qtp351210790-526] [puppetserver] Scope(Class[Pe_databases]) The backup functionality in the pe_databases module has been deprecated and will be removed in a future release.A notify resource works to output in a Puppet run but results in a change on every Puppet run.
Also added 'warning' note to the readme about the deprecation.