Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Maint) Rename PuppetlabsSpec::Puppet{Seams,Internals} #81

Merged

Conversation

jeffmccune
Copy link
Contributor

The module PuppetlabsSpec::PuppetSeams has been renamed in the
puppetlabs_spec_helper gem to PuppetlabsSpec::PuppetInternals.

The method to obtain a scope object has also changed slightly. Without this
patch the spec tests will fail because the stdlib module is not aligned with
the spec helper gem. This patch fixes the problem by matching up messages
with their receivers in the spec helper library.

Paired-with: Andrew Parker andy@puppetlabs.com

Requirements

Merging this into 2.2.x should be coordinated with the spec helper pull
request that renames these module methods:

puppetlabs/puppetlabs_spec_helper#18

The module PuppetlabsSpec::PuppetSeams has been renamed in the
puppetlabs_spec_helper gem to PuppetlabsSpec::PuppetInternals.

The method to obtain a scope object has also changed slightly.  Without
this patch the spec tests will fail because the stdlib module is not
aligned with the spec helper gem.  This patch fixes the problem by
matching up messages with their receivers in the spec helper library.

Paired-with: Andrew Parker <andy@puppetlabs.com>
jeffmccune pushed a commit that referenced this pull request Jul 23, 2012
…ternals

(Maint) Rename PuppetlabsSpec::Puppet{Seams,Internals}
@jeffmccune jeffmccune merged commit a1bab58 into puppetlabs:2.2.x Jul 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants