Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

Update from k3d v3 to k3d v4 #88

Merged
merged 3 commits into from
Jul 30, 2021
Merged

Update from k3d v3 to k3d v4 #88

merged 3 commits into from
Jul 30, 2021

Conversation

hunner
Copy link
Contributor

@hunner hunner commented May 15, 2021 •
edited by rick-a-lane-ii
Loading

Update k3d v3 to k3d v4

@hunner hunner requested a review from kyleterry May 15, 2021 00:01
@hunner hunner requested a review from a team as a code owner May 15, 2021 00:01
@hunner
Copy link
Contributor Author

hunner commented May 17, 2021 •
edited
Loading

Edit: this is due to outdated CRDs, updated in #89 Current changes still getting • failed to apply object 'apiextensions.k8s.io/v1, Kind=CustomResourceDefinition': CustomResourceDefinition.apiextensions.k8s.io "relaycores.install.relay.sh" is invalid: [spec.validation.openAPIV3Schema.properties[spec].properties[vault].default.sidecar.serverAddr: Required value, spec.validation.openAPIV3Schema.properties[spec].properties[vault].properties[sidecar].default.serverAddr: Required value] during cluster initialize.

@hunner hunner force-pushed the update_k3d branch 2 times, most recently from 9d5f04b to d0a3fda Compare May 17, 2021 17:55
kyleterry
kyleterry approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@kyleterry kyleterry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Before merging, though, I would give this a quick test against a cluster that was created with k3d v3 to see if it acts funny. If it does, we might want to bump the major on this release.

@hunner
Copy link
Contributor Author

hunner commented May 19, 2021

Okay. I no longer have a live cluster and there are other issues with creating new clusters (CRDs outdated, pvpool changes, permissions issues) in the existing dev env that aren't related to v3. If those are fixed, I could stand up a v3 and then test this, but I imagine this will just go in as part of all that work.

@hunner hunner force-pushed the update_k3d branch 2 times, most recently from eaf3a0b to 4637030 Compare May 25, 2021 16:20
@rick-a-lane-ii rick-a-lane-ii force-pushed the update_k3d branch 2 times, most recently from a366b87 to 85fdc1b Compare July 30, 2021 22:04
@rick-a-lane-ii rick-a-lane-ii merged commit e543828 into master Jul 30, 2021
@rick-a-lane-ii rick-a-lane-ii deleted the update_k3d branch July 30, 2021 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kyleterry kyleterry kyleterry approved these changes

@rick-a-lane-ii rick-a-lane-ii rick-a-lane-ii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hunner @kyleterry @rick-a-lane-ii