Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

Update CRDs to apply cleanly #89

Merged
merged 1 commit into from
May 19, 2021
Merged

Update CRDs to apply cleanly #89

merged 1 commit into from
May 19, 2021

Conversation

hunner
Copy link
Contributor

@hunner hunner commented May 17, 2021

The current CRDs fail with the error • failed to apply object 'apiextensions.k8s.io/v1, Kind=CustomResourceDefinition': CustomResourceDefinition.apiextensions.k8s.io "relaycores.install.relay.sh" is invalid: [spec.validation.openAPIV3Schema.properties[spec].properties[vault].default.sidecar.serverAddr: Required value, spec.validation.openAPIV3Schema.properties[spec].properties[vault].properties[sidecar].default.serverAddr: Required value]

Even with this update, the core-operator expects -tool-injection-pool and gets -tool-injection-image:

zmak% k logs pod/relay-core-v1-operator-b8455fc7c-7clxq operator
flag provided but not defined: -tool-injection-image
Usage of relay-operator:
[...]
  -tool-injection-pool string
        the name of a PVPool pool to use for injecting tools into containers

@hunner hunner requested a review from a team as a code owner May 17, 2021 22:35
@rick-a-lane-ii
Copy link
Contributor

Yeah, the change to update relay-core and relay to use the new PVPool is in-progress. As is updating relay to use the latest versions of Tekton and Knative.

@hunner hunner merged commit e69d58d into master May 19, 2021
@hunner hunner deleted the update_crds branch May 19, 2021 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants