Skip to content

Conversation

sbeaulie
Copy link
Contributor

@sbeaulie sbeaulie commented Oct 9, 2020

Status

[Ready for Merge]

Description

Before this change there was a non zero chance that two requests could be received
at the same millisecond and have the same jobid. Added the username as a prefix
to the job id. Also returns a useful message when ctrl-c or terminating the app while
in the ABS loop.

Related Issues

Todos

  • Tests
  • Documentation

Reviewers

@puppetlabs/dio
@highb
@briancain

Samuel Beaulieu added 2 commits October 9, 2020 10:23
Before this change there was a non zero chance that two requests could be received
at the same millisecond and have the same jobid. Added the username as a prefix
to the job id
to query ABS for the state of the request or to delete it
@sbeaulie sbeaulie requested review from a team, briancain and highb as code owners October 9, 2020 15:40
@sbeaulie
Copy link
Contributor Author

sbeaulie commented Oct 9, 2020

here is an example of ctrl-c when the ABS loop is running

$ floaty get debian-8-x86_64
Requesting VMs with job_id: samuel-1602257755201.  Will retry for up to an hour.
Waiting 1 seconds to check if ABS request has been filled.  Queue Position: 265... (x1)
^C

Floaty interrupted, you can query the state of your request via
1) `floaty query samuel-1602257755201` or delete it via
2) `floaty delete samuel-1602257755201`

@genebean genebean merged commit 221f6c1 into master Oct 9, 2020
@genebean genebean deleted the fix-jobid-uniqueness branch October 9, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants