Json output for delete/list + better ABS error handling #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonaldseanp
requested review from
briancain,
highb and
a team
as code owners
sbeaulie
reviewed
Aug 12, 2020
mcdonaldseanp
force-pushed
the
json_output
branch
from
17c0085 to
71628b8
Compare
briancain
suggested changes
Aug 12, 2020
mcdonaldseanp
force-pushed
the
json_output
branch
from
71628b8 to
a3647d6
Compare
This commit adds an option `--json` to the list and delete commands. When the json flag is used the commands will print output as formatted JSON rather than pretty printed strings.
When ABS returns an http status code other than 200 or 202, the ABS code should fail
mcdonaldseanp
force-pushed
the
json_output
branch
from
a3647d6 to
1eaa807
Compare
|
@briancain updated :) |
briancain
approved these changes
Aug 13, 2020
mattkirby
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
[Ready for Merge]
Description
Updates to the list and delete commands to include a
--jsonoption so those commands can be used with scripts and automation that require structured output.Additionally, add better error handling of status codes from ABS
Related Issues
Todos
Reviewers
@puppetlabs/dio
@highb
@briancain