Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚸 remove old rfc6266-parser package #182

Merged
merged 1 commit into from
Nov 19, 2021
Merged

🚸 remove old rfc6266-parser package #182

merged 1 commit into from
Nov 19, 2021

Conversation

HotelCalifornia
Copy link
Contributor

@HotelCalifornia HotelCalifornia commented Nov 18, 2021 •
edited
Loading

Summary:

remove uses of the rfc6266-parser package

Motivation:

it's been left without update since 2017, and a recent version of setuptools has broken one of its dependencies.

References (optional):

Test Plan:

  • download kernel/okapilib templates properly

kunwarsahni01
kunwarsahni01 approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@kunwarsahni01 kunwarsahni01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to update homebrew requirements as well

@kunwarsahni01 kunwarsahni01 merged commit cb3024f into develop Nov 19, 2021
@kunwarsahni01 kunwarsahni01 mentioned this pull request Nov 19, 2021
Closed
@kunwarsahni01 kunwarsahni01 deleted the feature/remove-rfc6266-parser branch November 19, 2021 17:00
@kunwarsahni01 kunwarsahni01 mentioned this pull request Nov 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunwarsahni01 kunwarsahni01 kunwarsahni01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HotelCalifornia @kunwarsahni01