Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Use Correct Linked Remote Name for Upload #199

Merged
merged 1 commit into from
Feb 11, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pros/serial/devices/vex/v5_device.py
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ def write_program(self, file: typing.BinaryIO, remote_name: str = None, ini: Con
remote_base = f'slot_{slot + 1}'
if target == 'ddr':
self.write_file(file, f'{remote_base}.bin', file_len=file_len, type='bin',
target='ddr', run_after=run_after, linked_filename=remote_name, **kwargs)
target='ddr', run_after=run_after, linked_filename=linked_remote_name, **kwargs)
return
if not isinstance(ini, ConfigParser):
ini = ConfigParser()
Expand All @@ -322,7 +322,7 @@ def write_program(self, file: typing.BinaryIO, remote_name: str = None, ini: Con
logger(__name__).info(f'Created ini: {ini_file}')

if linked_file is not None:
self.upload_library(linked_file, remote_name=remote_name, addr=linked_file_addr,
self.upload_library(linked_file, remote_name=linked_remote_name, addr=linked_file_addr,
compress=compress_bin, force_upload=kwargs.pop('force_upload_linked', False))
bin_kwargs = {k: v for k, v in kwargs.items() if v in ['addr']}
if (quirk & 0xff) == 1:
Expand Down