Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨No invalid characters in new project directory name #278

Merged
merged 8 commits into from
Apr 17, 2023
Merged

✨No invalid characters in new project directory name #278

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d4ec163
Added check for valid directory name when creating a project
Andrew-B-Chen Jan 16, 2023
ea02936
Removed pyinstaller from requirements.txt
Andrew-B-Chen Jan 16, 2023
fbc9ad6
Revert "Removed pyinstaller from requirements.txt"
Andrew-B-Chen Jan 27, 2023
1b8d26e
Revert "Added check for valid directory name when creating a project"
Andrew-B-Chen Jan 27, 2023
6802e80
Added check for invalid new project directory name
Andrew-B-Chen Jan 27, 2023
0970714
Added check for invalid directory characters
Apr 6, 2023
166a88e
Added check for non-ASCII characters
Apr 8, 2023
10aa85f
merge develop
ayushuk Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pros/conductor/conductor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,10 @@ def remove_template(project: Project, identifier: Union[str, BaseTemplate], remo
def new_project(self, path: str, no_default_libs: bool = False, **kwargs) -> Project:
if Path(path).exists() and Path(path).samefile(os.path.expanduser('~')):
raise dont_send(ValueError('Will not create a project in user home directory'))
for char in str(Path(path)):
if char in ['/', '?', '<', '>', '\\', ':', '*', '|', '^', '#', '%', '&', '$', '+', '!', '`', '\'', '=',
'@', '\'', '{', '}', '[', ']', '(', ')', '~'] or ord(char) > 127:
raise dont_send(ValueError(f'Invalid character found in directory name: \'{char}\''))
proj = Project(path=path, create=True)
if 'target' in kwargs:
proj.target = kwargs['target']
Expand Down