Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix offline resolve templates #321

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Conversation

mayankpatibandla
Copy link
Member

@mayankpatibandla mayankpatibandla commented Jan 26, 2024

Summary:

Get local templates regardless of early access

Motivation:

There is a bug with resolving templates where offline templates are not correctly resolved if the early access flag is not set

References (optional):

#296

Test Plan:

  • Ensure that local templates are correctly found regardless of the early access flag

@mayankpatibandla mayankpatibandla self-assigned this Jan 26, 2024
@ayushuk
Copy link
Member

ayushuk commented Jan 26, 2024

Has this been tested?

@mayankpatibandla
Copy link
Member Author

Partially, still need to check if this breaks lvgl and implement a better way of using the libraries.

Copy link
Member

@ayushuk ayushuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation, lets merge

@ayushuk ayushuk merged commit 4efc0c0 into develop Jan 31, 2024
10 checks passed
@ayushuk ayushuk deleted the fix-offline-resolve-templates branch January 31, 2024 13:39
@ayushuk ayushuk mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants