Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erase pure variables in uninstall handler #243

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Erase pure variables in uninstall handler #243

merged 1 commit into from
Dec 14, 2020

Conversation

jorgebucaran
Copy link
Contributor

Pure doesn't erase its state after uninstalling. This PR adds an uninstall event handler to deal with that.

@edouard-lopez
Copy link
Member

Thanks @jorgebucaran
How is this method called? Is it safe to extract it to a file so I can test it?

@jorgebucaran
Copy link
Contributor Author

jorgebucaran commented Dec 10, 2020

How is this method called?

Fisher emits the event here.

Is it safe to extract it to a file so I can test it?

You can try with fisher install jorgebucaran/pure and then fisher remove jorgebucaran/pure.

@edouard-lopez
Copy link
Member

@jorgebucaran I have some modification I want to push to your PR, but don't have the permissions. Could you change them so I can push ?

@jorgebucaran
Copy link
Contributor Author

  • Allow edits by maintainers

Done!

@edouard-lopez
Copy link
Member

Still not working :/

❯ git push --force
Enumerating objects: 29, done.
Counting objects: 100% (29/29), done.
Delta compression using up to 4 threads
Compressing objects: 100% (21/21), done.
Writing objects: 100% (21/21), 5.64 KiB | 1.13 MiB/s, done.
Total 21 (delta 12), reused 0 (delta 0)
remote: Resolving deltas: 100% (12/12), completed with 7 local objects.
To github.com:jorgebucaran/pure.git
 ! [remote rejected] jorgebucaran/master -> jorgebucaran/master (permission denied)
error: failed to push some refs to 'git@github.com:jorgebucaran/pure.git'

I created the PR with github CLI:

gh pr checkout jorgebucaran:master

@edouard-lopez
Copy link
Member

edouard-lopez commented Dec 13, 2020

Maybe you have a branch restriction in place that forbid me to do so?

@jorgebucaran
Copy link
Contributor Author

There aren't any restrictions as far as I can see. This is just a regular fork. Why don't we merge this and add it later? This PR is non-breaking too, by the way. 😄

@edouard-lopez edouard-lopez merged commit ba468eb into pure-fish:master Dec 14, 2020
@edouard-lopez edouard-lopez added the 🚀 enhancement performance, UX or maintainability label Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 enhancement performance, UX or maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants