Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next version #33

Merged
merged 60 commits into from
Mar 20, 2018
Merged

Next version #33

merged 60 commits into from
Mar 20, 2018

Conversation

safareli
Copy link
Contributor

@safareli safareli commented Feb 12, 2018 •
edited
Loading

fixes #26
fixes #28
fixes #30

@safareli safareli requested a review from garyb February 12, 2018 16:55
@safareli
remove maybe{Dir,File,Rel,Abs} is{Absolute,Relative}
8bed445 
in favor of SplitRelOrAbs SplitDirOrFile
@safareli safareli mentioned this pull request Feb 13, 2018
Closed
@safareli safareli force-pushed the refactor branch 2 times, most recently from 373fc41 to 6dad268 Compare February 15, 2018 15:57
@garyb
Copy link
Member

garyb commented Feb 24, 2018

I think that's it! Unless you there's anything else you can think of?

@safareli safareli changed the title WIP Refactor Next version Mar 20, 2018
garyb
garyb approved these changes Mar 20, 2018
View reviewed changes
Copy link
Member

@garyb garyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@safareli safareli merged commit 24f57e6 into purescript-contrib:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyb garyb garyb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@safareli @garyb