removed Quit, made emulateFinalizer #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good to me. Do we need to run this every 1s even though? Even at 60s it would be good enough to prevent memory leaks, wouldn't it? |
|
Changed to 60s. This works here, but I'm afraid it doesn't for purescript-halogen-echarts. (It's supposed to work w/o |
|
Ah ok. 👍! |
cryogenian
force-pushed
the
emulate-finalizer
branch
from
cd0e9da to
fbe06f8
Compare
cryogenian
added a commit
that referenced
this pull request
Jan 28, 2016
removed Quit, made emulateFinalizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr removes
finalizerfromAceComponent. Now keys of components that are presented in page and synchronized with autocomplete map every second.@garyb please review