Update for new Argonaut major version #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick update: most of the other affected libraries have been updated, so we'll cut a new package set soon. If it's possible to cut a new release of this library with the change sometime this week that would help ensure the transition is smooth. Let me know if there's anything else I can do to make sure this looks good! |
|
Thanks! If you're also able to make a release then I can use that release to update the Bower files of trout-client and hypertrout. It's not necessary wrt package sets, but that way Bower users are still covered. |
|
No problem @thomashoneyman and sorry for the delay. The new tag is |
|
Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argonaut's type-class-based codecs now use typed errors instead of string errors, so I'm updating affected libraries for compatibility with the new version.
I've bumped dependency versions in the Bower file, but the only major version bump is the
argonaut-codecsversion. Fortunately, this library compiles with both v6.0.0 and v7.0.0 (the new version), so even if Hyper isn't updated when the new package set comes out it will still build with the package set. I also removed the unnecessary dependency resolution for typelevel-eval.While here, I noticed that the spago.dhall file is using the old format --
mkPackagedoesn't exist anymore -- so I updated it to use a more recent package set and removed that line. I also noticed that the version of Pulp used in the package.json isn't compatible with the latest PureScript (v0.13.8), so I've updated it.While verifying that the project still compiles and passes tests with my changes I noticed that the tests fail to compile on v0.13.8 of the compiler due to a missing type annotation. I've added that type annotation so the tests work properly. I also noticed some compiler warnings about duplicate imports, which I've removed.
tldr; dependencies are updated, this library is compatible with the upcoming package set, and it is now also compatible with the latest PureScript tooling.