0.12 updates #30
Merged
0.12 updates #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewleon
force-pushed
the
0.12
branch
2 times, most recently
from
bc2eab4 to
a606d87
Compare
bumped deps use Effect instead of Eff fix travis
|
Giving up on getting travis to like this. It can't find |
|
Thanks for looking at this. I think it might be best to wait until a proper 0.12 release has been published and we don't need to rely on branches for upstream libraries. Incidentally if you use pulp 12.2.0, you won't need to use the |
hdgarrood
reviewed
May 3, 2018
test/Main.purs
Outdated
|
|
||
| type Test = forall e. Eff (assert :: ASSERT, buffer :: BUFFER, console :: CONSOLE | e) Unit | ||
| type Test = Effect Unit |
There was a problem hiding this comment.
Would you mind getting rid of this type synonym entirely? I think Effect Unit is concise enough that it doesn't really need aliasing any more.
|
Thanks for the PR, I've fixed a typo in a8746c6 and fixed some deprecation warnings around the Buffer constructor I was getting while running the tests in c08c5f9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bumped deps
use Effect instead of Eff