Update to PureScript v0.15.0 #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanMartinez
added
type: breaking change
|
I don’t know how to fix this test. JSDOM seems to have issues with XPath (from reading through their bug tracker). Maybe we disable it for now and open an issue unless perhaps @bbarker knows what’s going wrong |
|
This issue happened last time we were updating things for |
|
JSDOM was introduced to help with that: Personally I don’t feel like it’s a good use of time to try and fix this unless it’s quick and direct. I’d rather wrap around if we have time. We can disable tests in the meantime |
`global` isn't assigned until all modules are imprted By wrapping it in an async/await block, we defer importing Test.Main until after XPathResult hsa been defined
thomashoneyman
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Backlinking to purescript/purescript#4244
Migrates FFI to ES modules
Checklist: