Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v0.14.0-rc3 #181

Merged
merged 5 commits into from
Nov 6, 2020
Merged

Update to v0.14.0-rc3 #181

merged 5 commits into from
Nov 6, 2020

Conversation

paluh
Copy link
Contributor

@paluh paluh commented Oct 20, 2020

@paluh
Copy link
Contributor Author

paluh commented Oct 20, 2020

Includes #176

@srghma
Copy link
Contributor

srghma commented Oct 24, 2020

related #183

@JordanMartinez
Copy link
Contributor

@paluh please merge #183 into this PR

@kl0tl
Copy link
Member

kl0tl commented Oct 24, 2020

We could replace some uses of unsafeCoerce by Safe.Coerce.coerce in the implementations of Data.Array.NonEmpty.unsafeFromArray, Data.Array.NonEmpty.toArray and Data.Array.groupBy. This requires the NonEmptyArray constructor to be in scope so we should be careful not to re-export it from Data.Array.NonEmpty.

Sadly we can’t remove the last unsafeCoerce from Data.Array.unsafeFromArrayF implementation without strengthening its type with a Coercible (f (Array a)) (f (NonEmptyArray a)) constraint, so we should probably refrain from doing it (at least until we have constraint kinds and quantified constraints so we can define type Representational f = forall a b. Coercible a b => Coercible (f a) (f b)).

@paluh
Copy link
Contributor Author

paluh commented Oct 26, 2020

@JordanMartinez I've included #183 . Do we want to include suggestions by @kl0tl here too?

@JordanMartinez
Copy link
Contributor

I think we should do @kl0tl's suggestions in a separate PR. They aren't strictly needed to update this library to v0.14.0, but are welcome improvements.

@JordanMartinez
Copy link
Contributor

@paluh All dependencies are now satisfied again. We're still getting an error due to the following line:

[1/1 WarningParsingModule] src/Data/Array/ST.purs:34:30

  34  import Control.Monad.ST (ST, kind Region)

                                   ^^^^^^^^^^^

  

  Kind imports are deprecated and will be removed in a future release. Omit the 'kind' keyword instead.

We just need to delete the kind word.

Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI now builds. I've also looked through the changes made and have verified that no unicode syntax is being used.

We'll need a second approval before we can merge. Once merged, this will unblock purescript-transformers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants