Use arrow notation for FFI #27
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it's safe to assume ES6 compatibility now. Users may turn to Babel if necessary.
milesfrain
commented
May 3, 2020
| exports.log = function (s) { | ||
| return function () { | ||
| console.log(s); | ||
| return {}; |
There was a problem hiding this comment.
return {} seems unnecessary, It's the same as returning undefined (which is what these console functions return anyway), and even if something else is returned, PS will ignore it.
|
👎 from me, there's no real reason to do this, and now people might have to think about Babel where before it just worked. |
|
Agreed with @garyb. According to caniuse, 6% of people globally are using browsers which don’t support arrow functions; that’s too many to justify this, in my view. |
|
Found purescript/purescript#3714 to provide more background on the no-arrow decision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's safe to assume ES6 compatibility now.
Users may turn to Babel if necessary.