Skip to content

Why isn't BoundedEnum constraint used in defaultSucc and defaultPred? #28

@safareli

Description

@safareli

current implementation for defaultSucc and defaultPred is taking toEnum and fromEnum as arguments:

defaultSucc :: forall a. (Int -> Maybe a) -> (a -> Int) -> a -> Maybe a
defaultSucc toEnum' fromEnum' a = toEnum' (fromEnum' a + 1)

defaultPred :: forall a. (Int -> Maybe a) -> (a -> Int) -> a -> Maybe a
defaultPred toEnum' fromEnum' a = toEnum' (fromEnum' a - 1)

When it could also be implemented like this:

defaultSucc ::  a. BoundedEnum a => a -> Maybe a
defaultSucc = toEnum <<< (_ + 1) <<< fromEnum

defaultPred ::  a. BoundedEnum a => a -> Maybe a
defaultPred = toEnum <<< (_ - 1) <<< fromEnum

so why is it like that?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions