Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rethrow: throw a new, modified version of an exception #22

Closed
wants to merge 3 commits into from

Conversation

matthewleon
Copy link

It seems quite important to have something like this, which I was sadly unable to achieve without cheating the type system a bit.

If someone knows of a way to kill off the coercion, I'd be very happy to do so!

Copy link
Contributor

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I think the doc comment could be clarified a little though - maybe something more like "if an exception is thrown, ..." so that it's clear what happens if the action doesn't throw?

@matthewleon
Copy link
Author

I think the doc comment could be clarified a little though

Good catch. I think the new one is clearer.

Copy link
Contributor

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@matthewleon
Copy link
Author

this is probably superseded by #26

@hdgarrood
Copy link
Contributor

Yes, I think you're right. Thanks anyway!

@hdgarrood hdgarrood closed this May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants