Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions #177

Merged
merged 4 commits into from
Dec 5, 2020
Merged

Migrate to GitHub Actions #177

merged 4 commits into from
Dec 5, 2020

Conversation

thomashoneyman
Copy link
Member

This PR migrates lists to use GitHub Actions instead of Travis for CI, as discussed in semirings#17. It also updates the installation instructions to refer to Spago instead of Bower.

@thomashoneyman
Copy link
Member Author

I've removed the MonadZero instances in this library as the class was deprecated as discussed in control#62. However, I'm not totally clear on whether we are:

  • Preserving MonadZero and MonadZero instances across core until the class is removed, where control and any other library using the class will have a compiler warning for the deprecation, or
  • Preserving MonadZero only in control, and removing it from the other libraries in core.

Either way, we won't be able to use the censor-lib --strict command with psa in CI anymore for at least any library which is using the class, because we want this warning to be included in the passing build. See this failed build for what happens in CI right now with the warning:

https://github.com/purescript/purescript-lists/runs/1490231947

@thomashoneyman
Copy link
Member Author

I've re-added the instances to comply with the discussion in purescript/purescript-control#62. We'll have to take an additional step to get CI working with this warning.

@thomashoneyman
Copy link
Member Author

Backlinking to purescript/purescript#3962

@thomashoneyman
Copy link
Member Author

thomashoneyman commented Dec 5, 2020

CI passes due to censoring user-defined warnings. Backlinking to #176.

Copy link
Contributor

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants