added function codePointFromChar

[csicar]

while writing documentation for Data.String.CodePoints I realized that a function converting a char to a codepoint might be useful.
Correct me if I am wrong but the charcode should always be smaller than 0x10FFFF

[hdgarrood]

Looks good! Yes, the code point value of a Char is always less than 0xFFFF; see https://pursuit.purescript.org/builtins/docs/Prim#t:Char. I'll wait until #93 is resolved to merge this.

[hdgarrood]

Looks great, but I think the example doesn't quite work because we don't export the CodePoint constructor. Perhaps singleton (codePointFromChar 'B') == "B" would be better? Or you think of a better example we could use?

[csicar]

the new commit uses the representation, that show produces. What do you think?

[MonoidMusician]

Hi, looks good! Would you consider adding a conversion from Char (which has to be partial) to your PR? like this: MonoidMusician@7819fb4#diff-73034b1d5857b2ac02dfa778bea9ef06R63

Thanks!

[hdgarrood]

The problem with writing it this way is that it suggests that you can write codePointFromChar 'B' == CodePoint 0x42 into e.g. a repl and get true out; of course, you'll actually get "Unknown data constructor CodePoint.

I'd prefer something like this instead:

>>> codePointFromChar 'B'
CodePoint 0x42

[hdgarrood]

Thanks for putting up with my nitpicking! :)

[csicar]

I don't mind it. Thanks for merging!