Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.add is deprecated. #45

Closed
diakopter opened this issue May 25, 2015 · 4 comments
Closed

Object.add is deprecated. #45

diakopter opened this issue May 25, 2015 · 4 comments

Comments

@diakopter
Copy link

Are you trying to listen for the 'core:cancel' Atom command with jQuery::on?
jQuery::trigger can no longer be used to listen for Atom commands. Please
use atom.commands.add instead. See the docs at
https://atom.io/docs/api/latest/CommandRegistry

@jpatel531
Copy link
Contributor

Thanks for bringing this to my attention! I'll have a look at it later today

@jpatel531
Copy link
Contributor

Just to double-check, is this what you're referring to: https://atom.io/docs/v0.186.0/upgrading/upgrading-your-package#dispatching-commands ? It looks like they have been deprecated for 'atom-workspace' and 'atom-text-editor', but I am unsure about whether they apply to instances of atom-space-pen views, which is where the package listens for core:cancel. Am I missing something extra?

@diakopter
Copy link
Author

I dunno.. It was an auto-generated error/report.
On May 26, 2015 4:59 PM, "Jamie Patel" notifications@github.com wrote:

Just to double-check, is this what you're referring to:
https://atom.io/docs/v0.186.0/upgrading/upgrading-your-package#dispatching-commands
? It looks like they have been deprecated for 'atom-workspace' and
'atom-text-editor', but I am unsure about whether they apply to instances
of atom-space-pen views, which is where the package listens for
core:cancel. Am I missing something extra?


Reply to this email directly or view it on GitHub
#45 (comment).

jpatel531 added a commit that referenced this issue May 27, 2015
Replaced jquery events with atom command registry events. Resolves #46 and #45
@jpatel531
Copy link
Contributor

Version 1.1.6 has been released, which replaces these deprecated calls :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants