Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK #1

Merged
merged 10 commits into from
Feb 28, 2018
Merged

Update SDK #1

merged 10 commits into from
Feb 28, 2018

Conversation

lukabratos
Copy link
Contributor

What changed:

  • Change method name from notify to publish so it'll be in line with other server side SDK's.
  • Configure Coveralls, Travis.
  • Update README.

@@ -23,7 +22,7 @@ This configuration can be done anywhere you want, but if you are using rails the

```ruby
Pusher::PushNotifications.configure do |config|
 config.instance_id = ENV['PUSHER_INSTANCE_ID'] # or the value directly :)
 config.instance_id = ENV['PUSHER_INSTANCE_ID'] # or the value directly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@lukabratos lukabratos merged commit d229057 into master Feb 28, 2018
@lukabratos lukabratos deleted the update-sdk branch February 28, 2018 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants