[WIP] Initialization with function

[jpatel531]

New (and probably better way) of initializing the client

client := pusher.New("your_app_id", "your_app_key", "your_app_secret")

or with config options

client := pusher.NewWithConfig("your_app_id", "your_app_key", "your_app_secret", &pusher.Config{Secure: false, Host: "bla.bla.io"}

Allows validation of credentials etc. upon initialization (rather than the current struct initialization).

Might require a major release :/

WDYT @zimbatm

[zimbatm]

@jpatel531 sorry for the late reply.

I think I would force the constructor to check for the app_id, secret and key by making the values private in the struct. But then allow all the other properties directly on the struct.

type Client struct {
  appId string
  key string
  secret string
  Config *Config
  HttpClient *net.HttpClient
}

func New(appId, key, secret string) (*Client, error) {
  // check bla bla bla
  return Client{appId, key, secret, nil, nil}
}

and then the client can use the lib like:

import "github.com/pusher/pusher-http-go/client"
cli, err := client.New("app_id", "secret", "key")
cli.HttpClient = http.Client{...}
cli.ProxyWhatever = "..."
cli.Timeout = 2 * time.Second

[kn100]

closing due to age and divergence of this branch from the lib.