Implement missing Python calls to make Pandas usage natural #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added implementation for PyObject_RichCompare, PyNumber_Invert,
PyNumber_And, PyNumber_Or such that the usual filtering with in pandas
would be more natural. Previously, if you do:
Will error, because we only implemented PyObject_RichCompareBool, and it
will return a simple boolean, rather than a complex PyObject for
querying. By implementing PyObject_RichCompare, PyNumber_Invert,
PyNumber_And and PyNumber_Or, I believe we enabled full range of Pandas'
filtering short-hand now:
I double checked Swift type inference. If you just do:
The type system will still choose the right
PyObject_RichCompareBool
function.The confusion only happens if you do:
and you can workaround this by providing explicit type. I think this is a small
price to pay to enable a capable library such as Pandas usable within Swift.