Skip to content

Remove unused parameter from check_irradiance_consistency_qcrad #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Remove unused parameter from check_irradiance_consistency_qcrad #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pvanalytics/quality/irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ def _check_irrad_ratio(ratio, ghi, sza, bounds):
)


def check_irradiance_consistency_qcrad(ghi, solar_zenith, dni_extra, dhi, dni,
def check_irradiance_consistency_qcrad(ghi, solar_zenith, dhi, dni,
param=None):
"""Check consistency of GHI, DHI and DNI using QCRad criteria.

Expand All @@ -261,8 +261,6 @@ def check_irradiance_consistency_qcrad(ghi, solar_zenith, dni_extra, dhi, dni,
Global horizontal irradiance in :math:`W/m^2`
solar_zenith : Series
Solar zenith angle in degrees
dni_extra : Series
Extraterrestrial normal irradiance in :math:`W/m^2`
dhi : Series
Diffuse horizontal irradiance in :math:`W/m^2`
dni : Series
Expand Down
2 changes: 1 addition & 1 deletion pvanalytics/tests/quality/test_irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def test_check_irradiance_consistency_qcrad(irradiance_qcrad):
"""Test that QCRad identifies consistent irradiance measurements."""
expected = irradiance_qcrad
cons_comp, diffuse = irradiance.check_irradiance_consistency_qcrad(
expected['ghi'], expected['solar_zenith'], expected['dni_extra'],
expected['ghi'], expected['solar_zenith'],
expected['dhi'], expected['dni'])
assert_series_equal(cons_comp, expected['consistent_components'],
check_names=False)
Expand Down