-
Notifications
You must be signed in to change notification settings - Fork 37
Trim leading and trailing periods of missing data #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
6e2b6e3
Funciton to detect and remove leading and trailing gaps
wfvining ef9554f
Return boolean mask instead of trimming the series.
wfvining 0a23469
Trimming a series with no valid days returns all False
wfvining 0cc6335
Add gaps.valid_between and gaps.trim to API documentation
wfvining f95e83f
Add license and attribution for pvfleets_qa_analysis
wfvining 62e74da
Fix docstring indentation and spelling for gaps.trim()
wfvining 013d2e2
clarify valid data in documentation for 'valid_between'
wfvining d2ceb54
Tests for function that calculates a daily completeness index
wfvining a089410
Fix data types and use longer series in tests
wfvining 2c5d618
Raise a value error if the frequency passed to the function is bad
wfvining 324c6c4
Tests for completeness filtering function.
wfvining f255b51
Initial implementation of gaps.complete
wfvining 0dbc14b
Improve documentation.
wfvining 5a4fb54
Refactor valid_between to use daily_completeness
wfvining eedd93e
Rename valid_between to start_stop_dates.
wfvining b706080
Add new gaps functions to API documentation.
wfvining 17dd564
Update documentation for quality.gaps functions
wfvining eb29ada
Rename threshold parameter to gaps.complete function
wfvining e3c91d8
Rework gaps.complete for improved readability.
wfvining f97093f
Apply documentation changes suggested in code review.
wfvining 02df37e
Add keep_index arg to daily_completeness & rename completeness_score
wfvining 6552a8a
Improve clarity in calculation of seconds per sample.
wfvining 17fc35f
use a more descriptive variable name in gaps.trim
wfvining 82d87ff
Rework old tests for the new start_stop_dates API
wfvining 21cfb33
Rewrite trim function as trim_incomplete
wfvining 7ef91ea
Update references to daily_completeness in documentation
wfvining ef706f8
Documentation for more general 'gaps.trim' function
wfvining 9fc7a59
Generic function for trimming begining and end of time series
wfvining 941bf79
Apply suggestions from code review
wfvining ddf6bb6
Documentation improvements.
wfvining File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
Copyright (c) 2020 Alliance for Sustainable Energy, LLC. | ||
|
||
Redistribution and use in source and binary forms, with or without | ||
modification, are permitted provided that the following conditions are | ||
met: | ||
|
||
1. Redistributions of source code must retain the above copyright | ||
notice, this list of conditions and the following disclaimer. | ||
|
||
2. Redistributions in binary form must reproduce the above copyright | ||
notice, this list of conditions and the following disclaimer in the | ||
documentation and/or other materials provided with the | ||
distribution. | ||
|
||
3. Neither the name of the copyright holder nor the names of its | ||
contributors may be used to endorse or promote products derived | ||
from this software without specific prior written permission. | ||
|
||
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | ||
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | ||
HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | ||
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | ||
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | ||
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | ||
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.