Optionally label every interpolated/stale point (not just endpoints) #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds kwarg 'label_all' and _backfill_window funciton. If label_all is True then every point in a window that appears interpoated or stale is marked 'True'. If label_all is False then only the endpoint of the window is marked 'True'.
Move not about meaning of rtol and atol out of the parameters block.
cwhanse
approved these changes
May 28, 2020
wfvining
commented
May 28, 2020
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
Use same wording for both stale_values_diff and interpoaltion_diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43
Adds kwarg
label_alltogaps.stale_values_diffandgaps.interpolation_diff. Iflabel_all=Truethen every point in a window that appears interpolated or stale is markedTrue. Iflabel_all=Falsethen only the endpoint of the window is markedTrue.