Skip to content

Update test_psm3_tmy-2017.csv to match current NSRDB #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2020
Merged

Update test_psm3_tmy-2017.csv to match current NSRDB #1007

merged 2 commits into from
Jul 19, 2020

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Jul 18, 2020 •
edited
Loading

  • Closes Test failure: test_psm3::test_get_psm3_tmy #1005
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Seeing if Azure likes the update...

@kandersolar kandersolar added this to the 0.8.0 milestone Jul 18, 2020
@kandersolar
Copy link
Member Author

Looks like this worked. Scrolling through the Test_conda_linux checks, the failures are all test_tmy.py::test_read_tmy3_remote. There was one failure in the MIDC test suite, but I reran the check and it went away.

cwhanse
cwhanse approved these changes Jul 19, 2020
View reviewed changes
Copy link
Member

@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge when ready, @kanderso-nrel

@kandersolar kandersolar merged commit 39b3607 into pvlib:master Jul 19, 2020
@kandersolar kandersolar deleted the tmy2017 branch July 19, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wholmgren wholmgren wholmgren approved these changes

@cwhanse cwhanse cwhanse approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

Test failure: test_psm3::test_get_psm3_tmy
3 participants
@kandersolar @wholmgren @cwhanse