Skip to content

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Aug 29, 2021

  • Closes Missing Module Dependency - Tables #1252
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

@kandersolar kandersolar added this to the 0.9.0 milestone Aug 29, 2021
@kandersolar kandersolar marked this pull request as ready for review August 29, 2021 16:35
Copy link
Member

@mikofski mikofski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kevin, this feels good somehow :)

@wholmgren wholmgren merged commit 403f65e into pvlib:master Aug 30, 2021
@kandersolar kandersolar deleted the nix_tables branch August 30, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Module Dependency - Tables
4 participants