Make "data" argument required in ModelChain.run_model_from_effective_irradiance
#1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a required argument.
_prepare_temperature and _run_from_effective_irrad
kandersolar
reviewed
May 1, 2023
There was a problem hiding this comment.
Thanks @k10blogger! Can you please make these updates as well:
- Remove
default Nonefrom the docstring descriptions for thesedataparameters. For example on Line 1702, and the same for the other functions. - Add an entry to the what's new file, maybe something like this under
Bug Fixes:
* `data` can no longer be left unspecified in
:py:meth:`pvlib.modelchain.ModelChain.run_model_from_effective_irradiance`. (:issue:`1713`, :pull:`1720`)
- Add yourself to the Contributor's list at the bottom of the what's new file as well
|
Removed "default None" from doc string in following functions Added entry under bug fixes. |
kandersolar
approved these changes
May 1, 2023
kandersolar
changed the title
ModelChain.run_model_from_effective_irradiance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the issue here #1713 . Removed the None from the data argument in the function modelchain.run_model_from_effective_irradiance
modelchain._prepare_temperature
modelchain._run_from_effective_irradiance
Before and after change pyunittest remains the same.
======== 11 failed, 953 passed, 75 skipped, 2 xfailed, 1 xpassed, 82 warnings, 100 errors in 146.61s (0:02:26) ========datashould not be optional inModelChain.run_model_from_effective_irradiance#1713docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.