Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows/Conda CI error in test_singlediode.py #2007

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

echedey-ls
Copy link
Contributor

@echedey-ls echedey-ls commented Apr 12, 2024

Fixes the Windows-conda error by mocking the platform-variadic _lambert_v_from_i .

No need for a whatsnew entry I believe.

@echedey-ls echedey-ls changed the title [WAITING FOR CI TO FINISH] Fix Windows/Conda CI error in test_singlediode.py Fix Windows/Conda CI error in test_singlediode.py Apr 12, 2024
@echedey-ls echedey-ls marked this pull request as ready for review April 12, 2024 19:11
@cwhanse
Copy link
Member

cwhanse commented Apr 12, 2024

@kandersolar I'm OK with this.

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution. Thanks @echedey-ls!

@kandersolar kandersolar merged commit c2ac022 into pvlib:main Apr 15, 2024
29 of 30 checks passed
@echedey-ls echedey-ls deleted the fix-conda-errors-pls branch April 15, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variance in scipy.special.lambertw output depending on scipy version and installation source
3 participants