Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ixx equation in pvsystem.sapm #2019

Merged
merged 8 commits into from May 2, 2024
Merged

Fix Ixx equation in pvsystem.sapm #2019

merged 8 commits into from May 2, 2024

Conversation

cwhanse
Copy link
Member

@cwhanse cwhanse commented Apr 26, 2024

  • Closes Error in Ixx equation in pvsystem.sapm #2016
  • [X ] I am familiar with the contributing guidelines
  • Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Took this opportunity to tighten up one of the sapm tests as well.

@cwhanse cwhanse added the bug label Apr 26, 2024
@cwhanse cwhanse added this to the v0.10.5 milestone Apr 26, 2024
@kandersolar kandersolar mentioned this pull request May 2, 2024
@kandersolar kandersolar merged commit ec6fd33 into pvlib:main May 2, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in Ixx equation in pvsystem.sapm
2 participants