Codecov upload follow-up #2024
Merged
Codecov upload follow-up #2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR upload failed initially due to codecov's own token (the one it uses for PR uploads) hitting a rate limit. That will still be an unpredictable nuisance issue for us. Rerunning the job after a few minutes fixed it. Merging, and again checking to see if the upload on |
echedey-ls
pushed a commit
to echedey-ls/pvlib-python
that referenced
this pull request
May 22, 2024
supply codecov upload token to codecov upload jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.See #2008 and #2022. This PR adds a missing piece of the puzzle: making the codecov upload token available to the codecov upload steps. This is not necessary for PR uploads, but is needed for coverage to be uploaded correctly after merges to
main.After verifying that this new commit doesn't change/break anything regarding the PR upload, I plan to merge and see if it gets uploads working on
mainas well.