Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Small analytics update to CLI #4733

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Conversation

zateutsch
Copy link
Contributor

Changes:

  • Track MessageShow event with label attribute for campaign tracking (like for whisper)
  • appended the version property to all analytics events to keep track of CLI versioning

@zateutsch zateutsch requested a review from jgw96 June 4, 2024 18:34
Copy link
Contributor

Thanks zateutsch for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

Copy link
Contributor

@jgw96 jgw96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgw96 jgw96 added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 2b86f9e Jun 4, 2024
4 checks passed
@jgw96 jgw96 deleted the zteutsch/cli-analytics-update branch June 4, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants