-
Notifications
You must be signed in to change notification settings - Fork 18
New Web Manifest creating / auditing experience #68
Conversation
Icon update
Extra snippets
Awesome work. Few questions/comments:
|
Issues for things id like to add from the review so far. Note: These will be implemented separate from this PR. This is more just for my organization of things.
|
I like this editing experience a lot. One thing to note though, if you generate a new manifest, it doesn't have the screenshots field, and it results in warning highlight throughout the manifest. Could we just highlight the final bracket or something similar? This makes the other warnings/info hard to read, also pretty visually distracting. |
@nmetulev and @zateutsch this PR is ready for another review. I fixed the bugs that both of yall pointed out and made some UX tweaks based on Zach's feedback. Nikola, your two feature requests have been created too, and will be implemented separately from this PR. |
This PR implements the following:
With the above this PR completes: