Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 2 and add annotations #115

Open
Kludex opened this issue Apr 12, 2022 · 1 comment
Open

Drop python 2 and add annotations #115

Kludex opened this issue Apr 12, 2022 · 1 comment

Comments

@Kludex
Copy link
Member

Kludex commented Apr 12, 2022

Are there thoughts on what the title proposes? I can open a PR for it, if wanted.

@rabernat
Copy link

rabernat commented Nov 2, 2022

Thanks for this great package.

The fact that it does not distribute typing stubs causes some problems for downstream packages that want to use static typing. The typical use case is around ObjectID -- see e.g. python/mypy#6701 (comment).

I strongly support the suggestions to add type annotations and also to distribute stub files as part of the package

danigm added a commit to danigm/bson that referenced this issue Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants