Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Use ruff in CI #1609

Merged
merged 2 commits into from
Feb 5, 2023
Merged

DEV: Use ruff in CI #1609

merged 2 commits into from
Feb 5, 2023

Conversation

MartinThoma
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Base: 91.91% // Head: 91.91% // No change to project coverage 👍

Coverage data is based on head (a2ed96f) compared to base (d2c3e1b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1609   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files          33       33           
  Lines        6372     6372           
  Branches     1271     1271           
=======================================
  Hits         5857     5857           
  Misses        327      327           
  Partials      188      188           
Impacted Files Coverage Δ
pypdf/_page.py 90.50% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma merged commit d9d78da into main Feb 5, 2023
@MartinThoma MartinThoma deleted the ruff-ci branch February 5, 2023 13:06
MartinThoma added a commit that referenced this pull request Feb 5, 2023
NOTICE: pypdf changed the way it represents numbers parsed from PDF files.
  pypdf<3.4.0 represented numbers as Decimal, pypdf>=3.4.0 represents them as
  floats. Several other PDF libraries to this, as well as many PDF viewers.
  We hope to fix issues with too high precision like this and get a speed boost.
  In case your PDF documents rely on more than 18 decimals of precision you
  should check if it still works as expected.
  To clarify: This does not affect the text shown in PDF documents. It affects
  numbers, e.g. when graphics are drawn on the PDF or very exact positions are
  used. Typically, 5 decimals should be enough.

New Features (ENH)
-  Enable merging forms with overlapping names (#1553)
-  Add 'over' parameter to merge_transformend_page & co (#1567)

Bug Fixes (BUG)
-  Fix getter of the PageObject.rotation property with an indirect object (#1602)
-  Restore merge_transformed_page & co (#1567)
-  Replace decimal by float (#1563)

Robustness (ROB)
-  PdfWriter.remove_images: /Contents might not be in page_ref (#1598)

Developer Experience (DEV)
-  Introduce ruff (#1586, #1609)

Maintenance (MAINT)
-  Remove decimal (#1608)

[Full Changelog](3.3.0...3.4.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant