BUG: Fix getter of the PageObject.rotation property with an indirect object #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 91.89% // Head: 91.89% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1602 +/- ##
==========================================
- Coverage 91.89% 91.89% -0.01%
==========================================
Files 33 33
Lines 6246 6245 -1
Branches 1243 1243
==========================================
- Hits 5740 5739 -1
Misses 326 326
Partials 180 180
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MartinThoma
changed the title
|
Good work! If you want, I can add you to https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html :-) |
MartinThoma
added a commit
that referenced
this pull request
Feb 5, 2023
NOTICE: pypdf changed the way it represents numbers parsed from PDF files. pypdf<3.4.0 represented numbers as Decimal, pypdf>=3.4.0 represents them as floats. Several other PDF libraries to this, as well as many PDF viewers. We hope to fix issues with too high precision like this and get a speed boost. In case your PDF documents rely on more than 18 decimals of precision you should check if it still works as expected. To clarify: This does not affect the text shown in PDF documents. It affects numbers, e.g. when graphics are drawn on the PDF or very exact positions are used. Typically, 5 decimals should be enough. New Features (ENH) - Enable merging forms with overlapping names (#1553) - Add 'over' parameter to merge_transformend_page & co (#1567) Bug Fixes (BUG) - Fix getter of the PageObject.rotation property with an indirect object (#1602) - Restore merge_transformed_page & co (#1567) - Replace decimal by float (#1563) Robustness (ROB) - PdfWriter.remove_images: /Contents might not be in page_ref (#1598) Developer Experience (DEV) - Introduce ruff (#1586, #1609) Maintenance (MAINT) - Remove decimal (#1608) [Full Changelog](3.3.0...3.4.0)
|
Sure, that would be great. You can credit me as Mitchell Kotler and link
to https://github.com/mitchelljkotler
…On Sun, Feb 5, 2023 at 6:40 AM Martin Thoma ***@***.***> wrote:
Good work! If you want, I can add you to
https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html :-)
—
Reply to this email directly, view it on GitHub
<#1602 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABBHIXDONC2FTXL2FC5GLTWV6GSNANCNFSM6AAAAAAUQPSXMI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Done: e4853e4 :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#337 was fixed for rotating a page, but was still broken for getting the rotation angle if it was an indirect object. I have included a fix and a corresponding test.