Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Tolerate PDF with invalid xref pointed objects #2335

Merged
merged 13 commits into from
Mar 30, 2024
Merged

ENH: Tolerate PDF with invalid xref pointed objects #2335

merged 13 commits into from
Mar 30, 2024

Conversation

pubpub-zz
Copy link
Collaborator

closes #2326

@codecov Codecov
Copy link

codecov bot commented Dec 9, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.73%. Comparing base (42f970e) to head (550aa6e).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2335      +/-   ##
==========================================
+ Coverage   94.72%   94.73%   +0.01%     
==========================================
  Files          50       50              
  Lines        8239     8255      +16     
  Branches     1646     1651       +5     
==========================================
+ Hits         7804     7820      +16     
  Misses        267      267              
  Partials      168      168

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846
Copy link
Collaborator

stefan6419846 commented Dec 9, 2023 •
edited
Loading

It seems like this PR does not only fix #2326, but attempts to solve #2303 as well (which is covered by #2334 as well) and includes a copy of #2331.

I would argue that this should be split into three different clean PRs instead.

@MartinThoma MartinThoma changed the title ENH : tolerate pdf with invalid xref pointed objects ENH: Tolerate PDF with invalid xref pointed objects Dec 9, 2023
@MartinThoma
Copy link
Member

#2334 should be merged first as this pr (#2335) contains #2334

@MartinThoma MartinThoma added the on-hold PR requests that need clarification before they can be merged.A comment must give details label Dec 10, 2023
@stefan6419846
Copy link
Collaborator

Still blocked by #2334.

@pubpub-zz pubpub-zz mentioned this pull request Mar 30, 2024
Merged
@pubpub-zz
Copy link
Collaborator Author

the latest mods from #2334 (adding warnings) should be merged in

@pubpub-zz pubpub-zz removed the on-hold PR requests that need clarification before they can be merged.A comment must give details label Mar 30, 2024
stefan6419846
stefan6419846 reviewed Mar 30, 2024
View reviewed changes
pypdf/_reader.py Outdated Show resolved Hide resolved
stefan6419846
stefan6419846 reviewed Mar 30, 2024
View reviewed changes
pypdf/_reader.py Outdated Show resolved Hide resolved
stefan6419846
stefan6419846 reviewed Mar 30, 2024
View reviewed changes
tests/test_reader.py Outdated Show resolved Hide resolved
@stefan6419846 stefan6419846 merged commit 3a6e4d0 into py-pdf:main Mar 30, 2024
16 checks passed
stefan6419846 added a commit that referenced this pull request Apr 7, 2024
@stefan6419846
REL: 4.2.0
2ac88e6 
REL: 4.2.0

## What's new

### New Features (ENH)
- Allow multiple charsets for NameObject.read_from_stream (#2585) by @pubpub-zz
- Add support for /Kids in page labels (#2562) by @stefan6419846
- Allow to update fields on many pages (#2571) by @pubpub-zz
- Tolerate PDF with invalid xref pointed objects (#2335) by @pubpub-zz
- Add Enforce from PDF2.0 in viewer_preferences (#2511) by @pubpub-zz
- Add += and -= operators to ArrayObject (#2510) by @pubpub-zz

### Bug Fixes (BUG)
- Fix merge_page sometimes generating unknown operator 'QQ' (#2588) by @rfotino
- Fix fields update where annotations are kids of field (#2570) by @pubpub-zz
- Process CMYK images without a filter correctly (#2557) by @pubpub-zz
- Extract text in layout mode without finding resources (#2555) by @pubpub-zz
- Prevent recursive loop in some PDF files (#2505) by @pubpub-zz

### Robustness (ROB)
- Tolerate "truncated" xref (#2580) by @pubpub-zz
- Replace error by warning for EOD in RunLengthDecode/ASCIIHexDecode (#2334) by @pubpub-zz
- Rebuild xref table if one entry is invalid (#2528) by @pubpub-zz
- Robustify stream extraction (#2526) by @pubpub-zz

### Documentation (DOC)
- Update release process for latest changes (#2564) by @stefan6419846
- Encryption/decryption: Clone document instead of copying all pages (#2546) by @redfast00
- Minor improvements (#2542) by @j-t-1
- Update annotation list (#2534) by @j-t-1
- Update references and formatting (#2529) by @j-t-1
- Correct threads reference, plus minor changes (#2521) by @j-t-1
- Minor readability increases (#2515) by @j-t-1
- Simplify PaperSize examples (#2504) by @j-t-1
- Minor improvements (#2501) by @j-t-1

### Developer Experience (DEV)
- Remove unused dependencies (#2572) by @stefan6419846
- Remove page labels PR link from message (#2561) by @stefan6419846
- Fix changelog generator regarding whitespace and handling of "Other" group (#2492) by @stefan6419846
- Add REL to known PR prefixes (#2554) by @stefan6419846
- Release using the REL commit instead of git tag (#2500) by @MartinThoma
- Unify code between PdfReader and PdfWriter (#2497) by @pubpub-zz
- Bump softprops/action-gh-release from 1 to 2 (#2514) by @dependabot[bot]

### Maintenance (MAINT)
- Ressources → Resources (and internal name childs) (#2550) by @pubpub-zz
- Fix typos found by codespell (#2549) by @stefan6419846
- Update Read the Docs configuration (#2538) by @j-t-1
- Add root_object, _info and _ID to PdfReader (#2495) by @pubpub-zz

### Testing (TST)
- Allow loading truncated images if required (#2586) by @stefan6419846
- Fix download issues from #2562 (#2578) by @pubpub-zz
- Improve test_get_contents_from_nullobject to show real use-case (#2524) by @stefan6419846
- Add missing test annotations (#2507) by @stefan6419846

[Full Changelog](4.1.0...4.2.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan6419846 stefan6419846 stefan6419846 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to find 'endstream' marker for obj starting at 13367.
3 participants
@pubpub-zz @stefan6419846 @MartinThoma