Skip to content

[POST] pyOpenSci Fall Festival event page #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 9, 2024
Merged

[POST] pyOpenSci Fall Festival event page #462

merged 12 commits into from
Aug 9, 2024

Conversation

kierisi
Copy link
Contributor

@kierisi kierisi commented Aug 6, 2024

@lwasser I've got a draft of the Fall Festival event page up! I know there's still a lot of information to add to this, so I've kept it as a draft for now. my thought process is that we can make the first pass of initial changes, then publish what we have. and as we continue to build out the event I can keep the page updated.

let me know if you'd prefer we use a different process!

I know it's failing on trimming white space - I haven't fixed that (yet) since I figure there might be a big chunk of changes before we first publish.


@kierisi kierisi marked this pull request as draft August 6, 2024 20:07
@lwasser
Copy link
Member

lwasser commented Aug 7, 2024

oops - i think this conflicts with the other pr i merged today #461 i'm guessing it's minor as i think that was just the excerpt!

lwasser
lwasser previously approved these changes Aug 7, 2024
Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. i just left a few comments. i'm really waffling on the price again after chatting with carol. but 450 seems like a reasonable standard rate for year 1.

Co-authored-by: Leah Wasser <leah@pyopensci.org>
kierisi and others added 6 commits August 7, 2024 13:07
Co-authored-by: Leah Wasser <leah@pyopensci.org>
Co-authored-by: Leah Wasser <leah@pyopensci.org>
Co-authored-by: Leah Wasser <leah@pyopensci.org>
Co-authored-by: Leah Wasser <leah@pyopensci.org>
Co-authored-by: Leah Wasser <leah@pyopensci.org>
Co-authored-by: Leah Wasser <leah@pyopensci.org>
@kierisi kierisi marked this pull request as ready for review August 9, 2024 15:34
@kierisi
Copy link
Contributor Author

kierisi commented Aug 9, 2024

pre-commit.ci autofix

@kierisi kierisi merged commit cec1b94 into pyOpenSci:main Aug 9, 2024
4 checks passed
@kierisi kierisi deleted the fall-festival-event branch August 9, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants