-
Notifications
You must be signed in to change notification settings - Fork 72
[sept 17 merge] review: trusted publishing tutorial #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+154
−174
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
722c854
review: trusted publishing tutorial
lwasser d74838e
Apply suggestions from code review
lwasser 920d3b6
Apply suggestions from code review
lwasser 29013ee
docs(review): updates from review
lwasser 10ef74c
chore(deps): Update dependabot configuration for GitHub Actions (#577)
lwasser 04aff13
chore: bump the actions group (#579)
dependabot[bot] d7e8774
Fix: includes
lwasser f1f92bc
feat: literal includes for the action
lwasser c9abedd
docs: fix workflow
lwasser 7429c12
chore: fix errors from docs-test
lwasser cfe7167
Merge branch 'main' into tutorial-trusted-publishing
lwasser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that we have to install hatch manually here as i can't find a hatch specific action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For
model-transparency
formodel-signing
(which I started by following the pyOpenSci guides) we use the followinghttps://github.com/sigstore/model-transparency/blob/542d0db04c76d05063940488e5f25697731dfab7/.github/workflows/unit_tests.yml#L42-L43
But I just discovered that this always installs the latest hatch, despite pinning, so we'd need to look deeper into this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mihaimaruseac I wonder if perhaps that just installs Hatch from GitHub?? That is so curious. I believe you that it works, but Dependabot doesn't recognize it as an action, and we couldn't find the action. Maybe there is just some default behavior that we don't know about (or at least I don't know about it!!)
This is such a great tutorial. Thank you again for your work on it. ✨ And my apologies that it took so long for me to get to it.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is very likely. I'll debug this when I get some time and suggest an edit if needed
Thnak you very much for shepherding this with the final edits! Looking forward for more contributions