Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #129

Merged
merged 1 commit into from
May 25, 2023
Merged

Update README.md #129

merged 1 commit into from
May 25, 2023

Conversation

toncho11
Copy link
Collaborator

Updated how to use the docker file.

Updated how to use the docker file.
@gcattan
Copy link
Collaborator

gcattan commented May 25, 2023

Nice! Thank you @toncho11

Additionally, we could also push the docker image to the github repository:
https://github.com/pyRiemann/pyRiemann-qiskit/blob/main/.github/workflows/create_docker_image.yml

@gcattan gcattan merged commit 7b5cf5b into main May 25, 2023
@toncho11
Copy link
Collaborator Author

So what is the difference with https://github.com/pyRiemann/pyRiemann-qiskit/blob/main/Dockerfile ?

@gcattan
Copy link
Collaborator

gcattan commented May 25, 2023

The command you added to the readme is building the image in your local, and starts a container based on this image.
We could do the same on each release, and make the image available on GitHub. Then one can connect to the repo (docker login...) and download the docker image directly (without building it locally) (docker pull...).
The workflow I linked is the one we use to build the docker image for each PR. The two lines commented at the end push the image to the docker registry of this GitHub repo.
An improvement could be to listen not only for PRs, but also for release events, and enables the two last lines when it is a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants