-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example using Quantum MDM on real data #132
Conversation
Hi, very good. In addition, think we can test for different couples of distance and mean for both MDM and QuanticMDM. Do you want me to take a look at the flake8 error? |
Can we disable it temporally for now? :) Yes, there are a number of parameters to test:
|
List of things to test in order to evaluate the new algorithm:
|
There is still some issue with the regularization of the convex mean, so you can only use mean=convex with distance=euclid. We need to test with different datasets to see if this is consistent. Eventually, we could change the fit method inside QuanticMDM, to optimize these parameters depending on the data. |
# Conflicts: # pyriemann_qiskit/utils/distance.py
The mean returned by the docplex model still returns some zeros. It is a problem for other distances than the euclidian one. I tried the following:
It run, but the results were worst. @qbarthelemy do you have an idea? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no knowledge in the quantum field, but here are some comments.
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
- Change estimator for ERPCovariances
This PR is focused on testing the Quantum MDM on real data.
The process will take some time to validate the code and the results.