Remove warnings in financial example #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @qbarthelemy ! May be we can exclude this example from CI as it is very long to run. Or cache the results so we skip some computation on the Github action. |
…y/pyRiemann-qiskit into doc_example_financial
|
Can you try changing protobuf version from 4.25.0 to 4.25.1? |
|
Do not take into account my last message, it seems I can edit the Dockerfile myself. |
user12345678901
approved these changes
Nov 16, 2023
|
Everything looks ok to me:
Thank you for the changes @qbarthelemy ! |
gcattan
approved these changes
Nov 16, 2023
|
It's ok for me to merge. But, it seems that sometimes, the set of predictions by QSVM with y=1 is empty, raising an error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove warnings in financial example #195
Please wait for the build check in the doc before merging @gcattan