fix/halving search #210
Merged
fix/halving search #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
less variability in resulting estimator
- disminish threshold for two-stage
complete doc
qbarthelemy
approved these changes
Nov 21, 2023
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #209.
After investigation, the HalvingSearch seems fine.
So I added wherever it is possible a fixed random_state to improve reproducibility (random forest, qsvm, near miss, ...).
The random state inside QSVM was not exposed, so I implemented it in this PR.
Additionally, I updated some docs and reverted the simulator version (qiskit-aer) to 0.12.2, as I had some performance issues on my local windows with the new version (the pb is not visible on the Ci).
I took also the opportunity to reduce the search space and fed directly a good estimator when running on CI.
I re-ran the example a couple of times on GitHub and locally without seeing the error - I knock on wood.