Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/benchmark script #231

Merged
merged 2 commits into from
Dec 20, 2023
Merged

fix/benchmark script #231

merged 2 commits into from
Dec 20, 2023

Conversation

gcattan
Copy link
Collaborator

@gcattan gcattan commented Dec 20, 2023 •
edited
Loading

Addresses a couple of issues with the benchmark script:

  • the environment variables are not working with GitHub action. Using standard input/output.
  • Run benchmark only on pull, not on push.

Test:

  • Set score to 0 on PR, then checks the checks fail.

gcattan and others added 2 commits December 19, 2023 22:45
@gcattan
Update light_benchmark.py
ccef4ee
@gcattan @pre-commit-ci
Update light_benchmark.py (#34)
901486e 
* Update light_benchmark.py

test light_benchmark

* Update light_benchmark.py

https://stackoverflow.com/questions/70123328/how-to-set-environment-variables-in-github-actions-using-python

* [pre-commit.ci] auto fixes from pre-commit.com hooks

* use argv and output rather env variables

* [pre-commit.ci] auto fixes from pre-commit.com hooks

* typo

* [pre-commit.ci] auto fixes from pre-commit.com hooks

* remove 0

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@gcattan gcattan merged commit 8f96ae7 into pyRiemann:main Dec 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gcattan