Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract judge classifier to ensemble module #242

Merged
merged 57 commits into from
Feb 8, 2024
Merged

Extract judge classifier to ensemble module #242

merged 57 commits into from
Feb 8, 2024

Conversation

gcattan
Copy link
Collaborator

@gcattan gcattan commented Feb 1, 2024 •
edited
Loading

This PR moves the JudgeClassifier from the example with brain invader illiteracy to a new module ensemble.py.

gcattan and others added 22 commits February 1, 2024 14:22
@gcattan
Update classify_P300_bi_illiteracy.py
a47fce6 
Improve comments on the classify_P300_bi_iliteracy example
@gcattan
ensemble module
5cb256a
@gcattan
move JudgeClassifier to the ensemble module
fe6775d
@gcattan
push some comments on JudgeClassifier (missing fit and predict still)
fe0a0fc
@gcattan
complete comments
b3ba7c5
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
deda344
@gcattan
push tests
a7bf4d1
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
6ab2a83
@gcattan
fix tests
dab9df0
@gcattan
use np.array_equal
9af8e5a
@gcattan
missing import
6ea6e35
@gcattan
additional assert for fit
4e47d57
@gcattan
JudgeClassifier should inherits from BaseEstimator
6c9cf65
@gcattan
missing import
f92c0ee
@gcattan
missing import
b6cfcdf
@gcattan
fix get_params test
179739c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
045f145
@gcattan
fix JudgeClassifier
9149974
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
49cf6b9
@gcattan
add test for judge not required
e160e88
@gcattan
remove not used import
a5ea21c
@gcattan
fix seed for VQC on benchmark
c6286e5
@gcattan gcattan marked this pull request as ready for review February 3, 2024 20:00
@gcattan gcattan requested a review from qbarthelemy February 3, 2024 20:00
qbarthelemy
qbarthelemy reviewed Feb 5, 2024
View reviewed changes
pyriemann_qiskit/ensemble.py Outdated Show resolved Hide resolved
pyriemann_qiskit/ensemble.py Outdated Show resolved Hide resolved
pyriemann_qiskit/ensemble.py Outdated Show resolved Hide resolved
pyriemann_qiskit/ensemble.py Outdated Show resolved Hide resolved
pyriemann_qiskit/ensemble.py Outdated Show resolved Hide resolved
pyriemann_qiskit/ensemble.py Outdated Show resolved Hide resolved
gcattan and others added 5 commits February 6, 2024 19:29
@gcattan @qbarthelemy
Update pyriemann_qiskit/ensemble.py
7a6cdcb 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
@gcattan @qbarthelemy
Update pyriemann_qiskit/ensemble.py
0e1b7bb 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
@gcattan @qbarthelemy
Update pyriemann_qiskit/ensemble.py
9be726e 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
@gcattan @qbarthelemy
Update pyriemann_qiskit/ensemble.py
dc0f9d0 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
@gcattan @qbarthelemy
Update pyriemann_qiskit/ensemble.py
9fc0758 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
gcattan and others added 9 commits February 7, 2024 20:47
@gcattan @qbarthelemy
Update pyriemann_qiskit/ensemble.py
5277787 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
@gcattan @qbarthelemy
Update pyriemann_qiskit/ensemble.py
866d1da 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
@gcattan @qbarthelemy
Update pyriemann_qiskit/ensemble.py
b872ccc 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
@gcattan @qbarthelemy
Update pyriemann_qiskit/ensemble.py
149bd3a 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
@gcattan @qbarthelemy
Update pyriemann_qiskit/ensemble.py
84e6083 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
@gcattan @qbarthelemy
Update pyriemann_qiskit/ensemble.py
4f40884 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
@gcattan @qbarthelemy
Update tests/test_ensemble.py
bf4be05 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
@gcattan @qbarthelemy
Update tests/test_ensemble.py
4288245 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
@gcattan
fix pointer dereferencing
6b1de5e
qbarthelemy
qbarthelemy reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@qbarthelemy qbarthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you complete tests with a case with three classifiers in clfs?

pyriemann_qiskit/ensemble.py Outdated Show resolved Hide resolved
pyriemann_qiskit/ensemble.py Outdated Show resolved Hide resolved
pyriemann_qiskit/ensemble.py Outdated Show resolved Hide resolved
gcattan and others added 3 commits February 8, 2024 09:20
@gcattan @qbarthelemy
Update pyriemann_qiskit/ensemble.py
6ef0e2d 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
@gcattan @qbarthelemy
Update pyriemann_qiskit/ensemble.py
5eeec36 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
@gcattan @qbarthelemy
Update pyriemann_qiskit/ensemble.py
07bc522 
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
qbarthelemy
qbarthelemy reviewed Feb 8, 2024
View reviewed changes
pyriemann_qiskit/ensemble.py Outdated Show resolved Hide resolved
pyriemann_qiskit/ensemble.py Outdated Show resolved Hide resolved
qbarthelemy
qbarthelemy approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@qbarthelemy qbarthelemy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @gcattan !

@gcattan
Copy link
Collaborator Author

gcattan commented Feb 8, 2024

Thank you for the review @qbarthelemy :)

We are working on presenting some results on Q-MDM with @toncho11
Is it ok to send you a mail on your GH email?

@gcattan gcattan merged commit b774a48 into pyRiemann:main Feb 8, 2024
13 checks passed
@qbarthelemy
Copy link
Member

Is it ok to send you a mail on your GH email?
Yes, it's ok. @gcattan

@gcattan gcattan mentioned this pull request Feb 10, 2024
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qbarthelemy qbarthelemy qbarthelemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcattan @qbarthelemy