-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement of NCH #255
Improvement of NCH #255
Conversation
@qbarthelemy Can you complete the light benchmark, and check the scores after and before the changes ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example file classify_P300_nch.py needs to be updated with the new parameter name subsampling
and validated that it runs (python errors) and it completes correctly.
Currently I have this during the tests: FAILED tests/test_utils_distance.py::test_qdistance_logeuclid_to_convex_hull[optimizer0] - assert 8.567767282575056e-07 == 0 ± 1.0e-12 |
Have you update/pull my branch with my last commits? |
Add NCH to light_benchmark
fix warning in Ci/Cd
fix hull_type not renamed to subsampling
I do:
|
Fixes tests by adjusting the precision.
Improved comment on n_samples_per_hull = -1
LGTM! @qbarthelemy @toncho11 thank you for your work! |
This PR:
test_distance
(distance to hull of a point contained in the set is null),test_classification
addingQuanticNCH
(forgotten in Implementation of NCH (Nearest Convex Hull) classifier #253),classification
module.